Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix preprocessor conditional
Date: Tue, 09 Jun 2015 12:24:00 -0000	[thread overview]
Message-ID: <20150609122413.GA7453@blade.nx> (raw)
In-Reply-To: <1433841679-12499-1-git-send-email-gbenson@redhat.com>

This commit does have a ChangeLog entry; for some reason the
script I'm using didn't pick it up for the commit message :(

Gary Benson wrote:
> Hi all,
> 
> This commit fixes a typo in common/fileio.c where S_IWGRP was
> misspelled as S_IWRGRP in a preprocessor conditional, causing
> Host-I/O "vFile:fstat:" and File-I/O "Fstat" and "Ffstat"
> responses to always indicate files were not group-writable
> regardless of their actual status.
> 
> Pushed as obvious.
> 
> Thanks,
> Gary
> 
> ---
>  gdb/ChangeLog       |    5 +++++
>  gdb/common/fileio.c |    2 +-
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/common/fileio.c b/gdb/common/fileio.c
> index 28335ec..ef00ea8 100644
> --- a/gdb/common/fileio.c
> +++ b/gdb/common/fileio.c
> @@ -132,7 +132,7 @@ fileio_mode_pack (mode_t mode)
>    if (mode & S_IRGRP)
>      tmode |= FILEIO_S_IRGRP;
>  #endif
> -#ifdef S_IWRGRP
> +#ifdef S_IWGRP
>    if (mode & S_IWGRP)
>      tmode |= FILEIO_S_IWGRP;
>  #endif
> -- 
> 1.7.1

-- 
http://gbenson.net/


      reply	other threads:[~2015-06-09 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09  9:21 Gary Benson
2015-06-09 12:24 ` Gary Benson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609122413.GA7453@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox