From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3028 invoked by alias); 9 Jun 2015 12:24:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2964 invoked by uid 89); 9 Jun 2015 12:24:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Jun 2015 12:24:16 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CB17D2B64A0 for ; Tue, 9 Jun 2015 12:24:15 +0000 (UTC) Received: from blade.nx (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t59COE5c020089 for ; Tue, 9 Jun 2015 08:24:15 -0400 Received: by blade.nx (Postfix, from userid 1000) id E32202626FB; Tue, 9 Jun 2015 13:24:13 +0100 (BST) Date: Tue, 09 Jun 2015 12:24:00 -0000 From: Gary Benson To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix preprocessor conditional Message-ID: <20150609122413.GA7453@blade.nx> References: <1433841679-12499-1-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433841679-12499-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00123.txt.bz2 This commit does have a ChangeLog entry; for some reason the script I'm using didn't pick it up for the commit message :( Gary Benson wrote: > Hi all, > > This commit fixes a typo in common/fileio.c where S_IWGRP was > misspelled as S_IWRGRP in a preprocessor conditional, causing > Host-I/O "vFile:fstat:" and File-I/O "Fstat" and "Ffstat" > responses to always indicate files were not group-writable > regardless of their actual status. > > Pushed as obvious. > > Thanks, > Gary > > --- > gdb/ChangeLog | 5 +++++ > gdb/common/fileio.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/gdb/common/fileio.c b/gdb/common/fileio.c > index 28335ec..ef00ea8 100644 > --- a/gdb/common/fileio.c > +++ b/gdb/common/fileio.c > @@ -132,7 +132,7 @@ fileio_mode_pack (mode_t mode) > if (mode & S_IRGRP) > tmode |= FILEIO_S_IRGRP; > #endif > -#ifdef S_IWRGRP > +#ifdef S_IWGRP > if (mode & S_IWGRP) > tmode |= FILEIO_S_IWGRP; > #endif > -- > 1.7.1 -- http://gbenson.net/