From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: patrick@parcs.ath.cx
Cc: gdb-patches@sourceware.org, patrick@parcs.ath.cx
Subject: Re: [PATCH] Fix PR gdb/16999
Date: Wed, 13 May 2015 22:24:00 -0000 [thread overview]
Message-ID: <201505132224.t4DMOLg0002690@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1431555450-15493-1-git-send-email-patrick@parcs.ath.cx> (message from Patrick Palka on Wed, 13 May 2015 18:17:30 -0400)
>
> When GDB reads a nonsensical value for the HISTSIZE environment variable
> variable, i.e. one that is non-numeric or negative, GDB then sets its
> history size to 0. This behavior is contrary to that of bash, which
> defaults the history size to unlimited in such cases.
>
> This patch makes the behavior of invalid HISTSIZE match that of bash.
> When we encounter an invalid HISTSIZE we now set the history size to
> unlimited instead of 0.
The GDB behaviour makes more sense to me especially in light of:
> - /* Prefer ending up with no history rather than overflowing
> - readline's history interface, which uses signed 'int'
> - everywhere. */
next prev parent reply other threads:[~2015-05-13 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 22:17 Patrick Palka
2015-05-13 22:24 ` Mark Kettenis [this message]
2015-05-13 22:38 ` Patrick Palka
2015-05-14 9:16 ` Pedro Alves
2015-05-14 10:16 ` Pedro Alves
2015-05-14 12:06 ` Patrick Palka
2015-05-15 10:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505132224.t4DMOLg0002690@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox