From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81594 invoked by alias); 13 May 2015 22:24:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81539 invoked by uid 89); 13 May 2015 22:24:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 22:24:27 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id t4DMOL8P022418; Thu, 14 May 2015 00:24:21 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id t4DMOLg0002690; Thu, 14 May 2015 00:24:21 +0200 (CEST) Date: Wed, 13 May 2015 22:24:00 -0000 Message-Id: <201505132224.t4DMOLg0002690@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: patrick@parcs.ath.cx CC: gdb-patches@sourceware.org, patrick@parcs.ath.cx In-reply-to: <1431555450-15493-1-git-send-email-patrick@parcs.ath.cx> (message from Patrick Palka on Wed, 13 May 2015 18:17:30 -0400) Subject: Re: [PATCH] Fix PR gdb/16999 References: <1431555450-15493-1-git-send-email-patrick@parcs.ath.cx> X-SW-Source: 2015-05/txt/msg00350.txt.bz2 > > When GDB reads a nonsensical value for the HISTSIZE environment variable > variable, i.e. one that is non-numeric or negative, GDB then sets its > history size to 0. This behavior is contrary to that of bash, which > defaults the history size to unlimited in such cases. > > This patch makes the behavior of invalid HISTSIZE match that of bash. > When we encounter an invalid HISTSIZE we now set the history size to > unlimited instead of 0. The GDB behaviour makes more sense to me especially in light of: > - /* Prefer ending up with no history rather than overflowing > - readline's history interface, which uses signed 'int' > - everywhere. */