* New ARI warning Tue Apr 28 01:54:12 UTC 2015
@ 2015-04-28 10:03 GDB Administrator
2015-04-28 13:26 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2015-04-28 10:03 UTC (permalink / raw)
To: gdb-patches
169a170
> gdb/fbsd-nat.c:30: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h
gdb/fbsd-nat.c:30:#include <sys/wait.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: New ARI warning Tue Apr 28 01:54:12 UTC 2015 2015-04-28 10:03 New ARI warning Tue Apr 28 01:54:12 UTC 2015 GDB Administrator @ 2015-04-28 13:26 ` Joel Brobecker 2015-04-28 16:06 ` John Baldwin 0 siblings, 1 reply; 4+ messages in thread From: Joel Brobecker @ 2015-04-28 13:26 UTC (permalink / raw) To: John Baldwin; +Cc: gdb-patches John, On Tue, Apr 28, 2015 at 01:54:13AM +0000, GDB Administrator wrote: > 169a170 > > gdb/fbsd-nat.c:30: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h > gdb/fbsd-nat.c:30:#include <sys/wait.h> Looking at the file that triggered this new warning, I'd guess this one comes from one of your changes. It might make a little less sense in a -nat file to follow that rule, but I don't think it'd hurt, and this would avoid increasing the number of ARI hits. Would you mind fixing, please? -- Joel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Tue Apr 28 01:54:12 UTC 2015 2015-04-28 13:26 ` Joel Brobecker @ 2015-04-28 16:06 ` John Baldwin 2015-04-28 16:06 ` Joel Brobecker 0 siblings, 1 reply; 4+ messages in thread From: John Baldwin @ 2015-04-28 16:06 UTC (permalink / raw) To: gdb-patches; +Cc: Joel Brobecker On Tuesday, April 28, 2015 08:31:25 AM Joel Brobecker wrote: > John, > > On Tue, Apr 28, 2015 at 01:54:13AM +0000, GDB Administrator wrote: > > 169a170 > > > gdb/fbsd-nat.c:30: regression: wait.h: Do not include wait.h or sys/wait.h, instead include gdb_wait.h > > gdb/fbsd-nat.c:30:#include <sys/wait.h> > > Looking at the file that triggered this new warning, I'd guess > this one comes from one of your changes. It might make a little > less sense in a -nat file to follow that rule, but I don't think > it'd hurt, and this would avoid increasing the number of ARI hits. > Would you mind fixing, please? Not at all, does this look ok? Use "gdb_wait.h" instead of <sys/wait.h>. gdb/ChangeLog: * fbsd-nat.c: Include "gdb_wait.h" instead of <sys/wait.h>. --- diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index 066e288..9705d45 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -23,11 +23,11 @@ #include "regcache.h" #include "regset.h" #include "gdbthread.h" +#include "gdb_wait.h" #include <sys/types.h> #include <sys/procfs.h> #include <sys/ptrace.h> #include <sys/sysctl.h> -#include <sys/wait.h> #ifdef HAVE_KINFO_GETVMMAP #include <sys/user.h> #include <libutil.h> -- 2.2.1 -- John Baldwin ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Tue Apr 28 01:54:12 UTC 2015 2015-04-28 16:06 ` John Baldwin @ 2015-04-28 16:06 ` Joel Brobecker 0 siblings, 0 replies; 4+ messages in thread From: Joel Brobecker @ 2015-04-28 16:06 UTC (permalink / raw) To: John Baldwin; +Cc: gdb-patches > Not at all, does this look ok? Thanks! > Use "gdb_wait.h" instead of <sys/wait.h>. > > gdb/ChangeLog: > * fbsd-nat.c: Include "gdb_wait.h" instead of <sys/wait.h>. Looks good to me! -- Joel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-28 15:47 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-04-28 10:03 New ARI warning Tue Apr 28 01:54:12 UTC 2015 GDB Administrator 2015-04-28 13:26 ` Joel Brobecker 2015-04-28 16:06 ` John Baldwin 2015-04-28 16:06 ` Joel Brobecker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox