From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: arnez@linux.vnet.ibm.com (Andreas Arnez)
Cc: gdb-patches@sourceware.org, sergiodj@redhat.com (Sergio Durigan Junior)
Subject: Re: [PATCH 2/4] S390: Restructure s390_push_dummy_call
Date: Thu, 23 Apr 2015 16:03:00 -0000 [thread overview]
Message-ID: <20150423160310.6268DB8EB@oc7340732750.ibm.com> (raw)
In-Reply-To: <87d22w8324.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Apr 22, 2015 07:50:59 PM
Andreas Arnez wrote:
> * s390-linux-tdep.c
> (is_float_singleton): Remove function. Move the "singleton" part
> of the logic...
> (s390_effective_inner_type): ...here. New function.
> (is_float_like): Remove function. Inline its logic...
> (s390_function_arg_float): ...here.
> (is_pointer_like, is_integer_like, is_struct_like): Remove
> functions. Inline their logic...
> (s390_function_arg_integer): ...here.
> (s390_function_arg_pass_by_reference): Remove function.
> (extend_simple_arg): Remove function.
> (alignment_of): Remove function.
> (struct s390_arg_state): New structure.
> (s390_handle_arg): New function.
> (s390_push_dummy_call): Move parameter placement logic to the new
> function s390_handle_arg. Call it for calculating the stack area
> sizes first, and again for actually writing the parameters.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-04-23 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 17:45 [PATCH 0/4] S390: Vector ABI support Andreas Arnez
2015-04-22 17:49 ` [PATCH 1/4] S390: For zero, let is_power_of_two() return false Andreas Arnez
2015-04-23 16:02 ` Ulrich Weigand
2015-04-22 17:51 ` [PATCH 2/4] S390: Restructure s390_push_dummy_call Andreas Arnez
2015-04-23 16:03 ` Ulrich Weigand [this message]
2015-04-22 17:51 ` [PATCH 3/4] S390: Re-arrange implementation of s390_return_value Andreas Arnez
2015-04-23 16:03 ` Ulrich Weigand
2015-04-22 17:52 ` [PATCH 4/4] S390: Vector ABI support Andreas Arnez
2015-04-22 17:58 ` Andreas Arnez
2015-04-23 16:07 ` Ulrich Weigand
2015-04-24 14:46 ` Andreas Arnez
2015-04-23 16:47 ` Eli Zaretskii
2015-04-27 9:41 ` [PATCH 0/4] " Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423160310.6268DB8EB@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox