From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93680 invoked by alias); 23 Apr 2015 16:03:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93667 invoked by uid 89); 23 Apr 2015 16:03:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 23 Apr 2015 16:03:16 +0000 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Apr 2015 17:03:13 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 23 Apr 2015 17:03:12 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 80A60219005E for ; Thu, 23 Apr 2015 17:02:55 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t3NG3Bxh45482162 for ; Thu, 23 Apr 2015 16:03:11 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t3NG3ArA008868 for ; Thu, 23 Apr 2015 10:03:11 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-100.boeblingen.de.ibm.com [9.152.213.100]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t3NG3AC4008855; Thu, 23 Apr 2015 10:03:10 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 6268DB8EB; Thu, 23 Apr 2015 18:03:10 +0200 (CEST) Subject: Re: [PATCH 2/4] S390: Restructure s390_push_dummy_call To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Thu, 23 Apr 2015 16:03:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, sergiodj@redhat.com (Sergio Durigan Junior) In-Reply-To: <87d22w8324.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Apr 22, 2015 07:50:59 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150423160310.6268DB8EB@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042316-0041-0000-0000-0000042E79B3 X-SW-Source: 2015-04/txt/msg00896.txt.bz2 Andreas Arnez wrote: > * s390-linux-tdep.c > (is_float_singleton): Remove function. Move the "singleton" part > of the logic... > (s390_effective_inner_type): ...here. New function. > (is_float_like): Remove function. Inline its logic... > (s390_function_arg_float): ...here. > (is_pointer_like, is_integer_like, is_struct_like): Remove > functions. Inline their logic... > (s390_function_arg_integer): ...here. > (s390_function_arg_pass_by_reference): Remove function. > (extend_simple_arg): Remove function. > (alignment_of): Remove function. > (struct s390_arg_state): New structure. > (s390_handle_arg): New function. > (s390_push_dummy_call): Move parameter placement logic to the new > function s390_handle_arg. Call it for calculating the stack area > sizes first, and again for actually writing the parameters. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com