Re: [PATCH v5 1/9] sim/erc32: Switched emulated memory to host endian order.

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

On 03 Apr 2015 22:35, Jiri Gaisler wrote:
> 	* erc32.c (fetch_bytes): Remove. (store_bytes) Remove byte twisting.
> 	(memory_read) Access memory directly. (extract_short,
> 	extract_short_signed, extract_byte, extract_byte_signed) New
> 	function for for sub-word LD instructions.

each (...) section should be on a new line and have a colon:
	* erc32.c (current_target_byte_order): Delete.
	(fetch_bytes): Remove.
	(store_bytes): Remove byte twisting.
	...etc...

> 	* func.c (disp_ctrl, dis_mem): Ajust print-out to new data endian.
> 
> 	* interf.c (sim_open): Set dinfo to host endian to get correct disassembly.
> 	(sim_write, sim_read): Convert endian when gdb reads or writes memory.

the changelog, while covering more, still was incomplete.  i filled it out this 
time, but i really dislike doing this.

>  
> -int
> -sim_read(sd, mem, buf, length)
> -     SIM_DESC sd;
> -     SIM_ADDR mem;
> -     unsigned char *buf;
> -     int length;
> +sim_read (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length)

you accidentally deleted the return type "int" here.  i restored it and merged 
the patch.  i'm not terribly happy with it, but clearly you're improving on the 
status quo, and holding it up for the perfect world (converting erc32 to 
common/) is being unreasonable.  sorry for the delay at any rate.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]