From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2404 invoked by alias); 19 Apr 2015 06:35:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1865 invoked by uid 89); 19 Apr 2015 06:33:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 19 Apr 2015 06:33:26 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id B7C47340DE1; Sun, 19 Apr 2015 06:33:24 +0000 (UTC) Date: Sun, 19 Apr 2015 06:35:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 1/9] sim/erc32: Switched emulated memory to host endian order. Message-ID: <20150419063323.GA17952@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1428093356-7296-1-git-send-email-jiri@gaisler.se> <1428093356-7296-2-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <1428093356-7296-2-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00717.txt.bz2 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1351 On 03 Apr 2015 22:35, Jiri Gaisler wrote: > * erc32.c (fetch_bytes): Remove. (store_bytes) Remove byte twisting. > (memory_read) Access memory directly. (extract_short, > extract_short_signed, extract_byte, extract_byte_signed) New > function for for sub-word LD instructions. each (...) section should be on a new line and have a colon: * erc32.c (current_target_byte_order): Delete. (fetch_bytes): Remove. (store_bytes): Remove byte twisting. ...etc... > * func.c (disp_ctrl, dis_mem): Ajust print-out to new data endian. >=20 > * interf.c (sim_open): Set dinfo to host endian to get correct disassemb= ly. > (sim_write, sim_read): Convert endian when gdb reads or writes memory. the changelog, while covering more, still was incomplete. i filled it out = this=20 time, but i really dislike doing this. >=20=20 > -int > -sim_read(sd, mem, buf, length) > - SIM_DESC sd; > - SIM_ADDR mem; > - unsigned char *buf; > - int length; > +sim_read (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) you accidentally deleted the return type "int" here. i restored it and mer= ged=20 the patch. i'm not terribly happy with it, but clearly you're improving on= the=20 status quo, and holding it up for the perfect world (converting erc32 to=20 common/) is being unreasonable. sorry for the delay at any rate. -mike --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVM0wzAAoJEEFjO5/oN/WBqUUQAK3bi/HASGywBwBxSbB8rrz4 DCYXe+6ABWBa/g6XyBBrtZAcfAQSGUwqIXiTSbyy/OtVLB957hhQdWR7n/g25umP CUfklDrM2J4dfc/06Fu6v0gMqEluNeM6oJ5BuN58RTZLBnrfwxJGSavn7DgyiI0E Kxhbgpnq81BsnB1dsk7JaqAowI1SgLGpKenzGGDiF5cUwwsCam/MsNGbBWAVqxqA zYli0ChKneuvb8OwVMWQF2gHCv+jFzV+xp7k/FzWRojexFWwIlJdwjP7yjOuWdHV gbp5703Nngjy/4bAH9jzwH7fpGbEi+3g1UMD99UyGstC/gHBmTSJzh0RMvCIoRy7 s+5dqSCE7Yq8p0w/Gv519kAVFhY4Pw2uVx70mGcHEKA5qo1R6aXM/PNNlGvm9fqt 3ZyCFUnLCi2g1M2lnWTSP1W6/HMPvx9JD/Zxi+LnPr8cr4dj0kN87WYeOTLtDZpV MXnmIo0ETvdLM18JSR9ZP6RcQGUjfIy5CnEGIXbPHGL7931YPbOD+14Gsz5CmQTL eAm7hJc1NaGm1dwW42wZfOnOz09aGYaM7JM8mAY7JQB+jcvVxjNJhtvzTJsitRC7 KlQ6+fO/YZlAAsIqEEvBW+seMyqiyuQHZwbgPIQdmWSMIgnEHyeNs8bhZf794ITF O5bc75sxpYz5tamOcif6 =vDfh -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--