From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Some Python 3 fixes
Date: Wed, 15 Apr 2015 15:40:00 -0000 [thread overview]
Message-ID: <20150415154046.GK4704@adacore.com> (raw)
In-Reply-To: <552E833F.50706@ericsson.com>
> > gdb/ChangeLog:
> >
> > * python/lib/gdb/command/unwinders.py: Add parentheses.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.python/py-framefilter.py (ErrorFilter.filter): Use map function
> > if itertools.imap is not present.
> > * gdb.python/py-objfile.exp: Add parentheses.
> > * gdb.python/py-type.exp: Same.
> > * gdb.python/py-unwind-maint.py: Same.
Sorry for the delay, Simon. Most of those are on the obvious side
(print being a function, now, and thus requiring the use of
parentheses), so they'd be OK to push without approval. The one
change that is less obvious is the adjustment after itertools.imap
got replaced by "map"; but the change looks good to me.
So go ahead and push.
--
Joel
next prev parent reply other threads:[~2015-04-15 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 17:13 Simon Marchi
2015-04-15 15:27 ` Simon Marchi
2015-04-15 15:40 ` Joel Brobecker [this message]
2015-04-15 15:56 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415154046.GK4704@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox