From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110030 invoked by alias); 15 Apr 2015 15:40:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110021 invoked by uid 89); 15 Apr 2015 15:40:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Apr 2015 15:40:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9AA93D3D37; Wed, 15 Apr 2015 11:40:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iDh3fhtOnEp5; Wed, 15 Apr 2015 11:40:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6AB68D3803; Wed, 15 Apr 2015 11:40:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0673040EAD; Wed, 15 Apr 2015 08:40:47 -0700 (PDT) Date: Wed, 15 Apr 2015 15:40:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches Subject: Re: [PATCH] Some Python 3 fixes Message-ID: <20150415154046.GK4704@adacore.com> References: <1428426786-7704-1-git-send-email-simon.marchi@ericsson.com> <552E833F.50706@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552E833F.50706@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-04/txt/msg00576.txt.bz2 > > gdb/ChangeLog: > > > > * python/lib/gdb/command/unwinders.py: Add parentheses. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.python/py-framefilter.py (ErrorFilter.filter): Use map function > > if itertools.imap is not present. > > * gdb.python/py-objfile.exp: Add parentheses. > > * gdb.python/py-type.exp: Same. > > * gdb.python/py-unwind-maint.py: Same. Sorry for the delay, Simon. Most of those are on the obvious side (print being a function, now, and thus requiring the use of parentheses), so they'd be OK to push without approval. The one change that is less obvious is the adjustment after itertools.imap got replaced by "map"; but the change looks good to me. So go ahead and push. -- Joel