From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Zero supplied stat buffers in functions that pretend to stat
Date: Tue, 14 Apr 2015 08:04:00 -0000 [thread overview]
Message-ID: <20150414080403.GA524@blade.nx> (raw)
In-Reply-To: <552C3AF4.4000604@redhat.com>
Pedro Alves wrote:
> On 04/13/2015 10:40 PM, Gary Benson wrote:
> > GDB has five places where it pretends to stat for bfd_openr_iovec.
> > Four of these only set the incoming buffer's st_size, leaving the
> > other fields unchanged, which is to say very likely populated with
> > random values from the stack. remote_bfd_iovec_stat was fixed in
> > 0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the
> > other four.
> >
> > Built and and regtested on RHEL6.6 x86_64.
> >
> > Ok to commit?
>
> Eh, how apropos for the bfd cache discussion.
Yeah, I've been meaning to reply to that :)
> OK, thanks.
Will push it later.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-04-14 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 21:40 Gary Benson
2015-04-13 21:54 ` Pedro Alves
2015-04-14 8:04 ` Gary Benson [this message]
2015-04-14 11:37 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414080403.GA524@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox