From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39454 invoked by alias); 14 Apr 2015 08:04:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39445 invoked by uid 89); 14 Apr 2015 08:04:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 14 Apr 2015 08:04:06 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B28AC8EA47 for ; Tue, 14 Apr 2015 08:04:05 +0000 (UTC) Received: from blade.nx (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3E8444M015892; Tue, 14 Apr 2015 04:04:05 -0400 Received: by blade.nx (Postfix, from userid 1000) id 913D2263FB8; Tue, 14 Apr 2015 09:04:03 +0100 (BST) Date: Tue, 14 Apr 2015 08:04:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Zero supplied stat buffers in functions that pretend to stat Message-ID: <20150414080403.GA524@blade.nx> References: <1428961250-23031-1-git-send-email-gbenson@redhat.com> <552C3AF4.4000604@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552C3AF4.4000604@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00510.txt.bz2 Pedro Alves wrote: > On 04/13/2015 10:40 PM, Gary Benson wrote: > > GDB has five places where it pretends to stat for bfd_openr_iovec. > > Four of these only set the incoming buffer's st_size, leaving the > > other fields unchanged, which is to say very likely populated with > > random values from the stack. remote_bfd_iovec_stat was fixed in > > 0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the > > other four. > > > > Built and and regtested on RHEL6.6 x86_64. > > > > Ok to commit? > > Eh, how apropos for the bfd cache discussion. Yeah, I've been meaning to reply to that :) > OK, thanks. Will push it later. Cheers, Gary -- http://gbenson.net/