Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

On 19 Mar 2015 15:51, Nick Clifton wrote:
>   The patch below fixes a problem with the RL78 simulator simulation of
>   the G13 multiply/divide peripheral.  Namely the MDB register is not
>   32-bit aligned so the mem_put_si and mem_get_si functions cannot be
>   used with it.  Instead the value has to be split up into two 16-bit
>   parts and the mem_{get|put}_hi functions used.
> 
>   In addition the patch adds support for the new G13 and G14 flags in
>   RL78 ELF headers.  If one of these flag bits is present then the patch
>   selects the appropriate G10/G13/G14 emulation mode.

did you forgot to commit some other change ?  rl78 fails to build now:

gcc -DHAVE_CONFIG_H     -DPROFILE=1 -DWITH_PROFILE=-1          
-DDEFAULT_INLINE=0           -Wall   -I. -I../../../../sim/rl78 -I../common 
-I../../../../sim/rl78/../common -I../../include 
-I../../../../sim/rl78/../../include -I../../bfd 
-I../../../../sim/rl78/../../bfd -I../../opcodes 
-I../../../../sim/rl78/../../opcodes  -g -O2 -c -o load.o -MT load.o -MMD -MP 
-MF .deps/load.Tpo ../../../../sim/rl78/load.c
../../../../sim/rl78/load.c: In function 'rl78_load':
../../../../sim/rl78/load.c:95:3: error: 'rl78_g10_mode' undeclared (first use 
in this function)
   rl78_g10_mode = 0;
   ^
../../../../sim/rl78/load.c:95:3: note: each undeclared identifier is reported 
only once for each function it appears in
../../../../sim/rl78/load.c:99:16: error: 'g13_multiply' undeclared (first use 
in this function)
     case E_FLAG_RL78_G13: g13_multiply = 1; break;
                ^
Makefile:530: recipe for target 'load.o' failed
make[2]: *** [load.o] Error 1

i don't see either of those identifiers in the current master.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]