From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128475 invoked by alias); 23 Mar 2015 08:19:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128463 invoked by uid 89); 23 Mar 2015 08:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Mar 2015 08:19:24 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 8F4E83407E9; Mon, 23 Mar 2015 08:19:22 +0000 (UTC) Date: Mon, 23 Mar 2015 08:19:00 -0000 From: Mike Frysinger To: Nick Clifton Cc: dj@redhat.com, gdb-patches@sourceware.org Subject: Re: RFA: RL78: Fix simulation of G13 multiply/divide peripheral Message-ID: <20150323081833.GC8039@vapier> Mail-Followup-To: Nick Clifton , dj@redhat.com, gdb-patches@sourceware.org References: <87fv91nfy3.fsf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PHCdUe6m4AxPMzOu" Content-Disposition: inline In-Reply-To: <87fv91nfy3.fsf@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00707.txt.bz2 --PHCdUe6m4AxPMzOu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1756 On 19 Mar 2015 15:51, Nick Clifton wrote: > The patch below fixes a problem with the RL78 simulator simulation of > the G13 multiply/divide peripheral. Namely the MDB register is not > 32-bit aligned so the mem_put_si and mem_get_si functions cannot be > used with it. Instead the value has to be split up into two 16-bit > parts and the mem_{get|put}_hi functions used. >=20 > In addition the patch adds support for the new G13 and G14 flags in > RL78 ELF headers. If one of these flag bits is present then the patch > selects the appropriate G10/G13/G14 emulation mode. did you forgot to commit some other change ? rl78 fails to build now: gcc -DHAVE_CONFIG_H -DPROFILE=3D1 -DWITH_PROFILE=3D-1=20=20=20=20=20=20= =20=20=20=20 -DDEFAULT_INLINE=3D0 -Wall -I. -I../../../../sim/rl78 -I../comm= on=20 -I../../../../sim/rl78/../common -I../../include=20 -I../../../../sim/rl78/../../include -I../../bfd=20 -I../../../../sim/rl78/../../bfd -I../../opcodes=20 -I../../../../sim/rl78/../../opcodes -g -O2 -c -o load.o -MT load.o -MMD -= MP=20 -MF .deps/load.Tpo ../../../../sim/rl78/load.c ../../../../sim/rl78/load.c: In function 'rl78_load': ../../../../sim/rl78/load.c:95:3: error: 'rl78_g10_mode' undeclared (first = use=20 in this function) rl78_g10_mode =3D 0; ^ ../../../../sim/rl78/load.c:95:3: note: each undeclared identifier is repor= ted=20 only once for each function it appears in ../../../../sim/rl78/load.c:99:16: error: 'g13_multiply' undeclared (first = use=20 in this function) case E_FLAG_RL78_G13: g13_multiply =3D 1; break; ^ Makefile:530: recipe for target 'load.o' failed make[2]: *** [load.o] Error 1 i don't see either of those identifiers in the current master. -mike --PHCdUe6m4AxPMzOu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVD8yKAAoJEEFjO5/oN/WBMUsP/1dt/wnYjLDvWs0txA6OP64Z LWJx+RolL2bC2BkMVxwQfJzCeKyhlxv8lO93AgHVXzq+2hYGfO/jfVFW0FLXXzg5 tufJgX9CVso3o/dIOFdfMmkvaowT+ygF6j4Iw8uX4aymDhvCDEEkEr+YdwG76HRs 8Me+jPTKSjRi22Zmt412GgqnghB+Q/h93J40Yj5NPrDlNWCrS4AmbcVh0wdF8h5l GmloubTMR2MEv+Hwr8zmRN9fP0da4tPmq6/hNQmR4rCcM9SlTP+TtpiY2D7jeZVw Xgny7hvWgQXmz5xOsZTsIOXTVpvKa9nBiErcb1QiWl8B8LhqqKhZdQ1P9ZRUhCRW l5XfLwz2N/tgEwZgzjP1qwqJIMgFvFi2ugA9u5jrCz1ztNhWczYNM2jSsKfOAz9L N7VW1VOkrqYBbQJVz4ir+EmltFMETqlizspVtpzCxbhoCd8y+kOPiLR6ACVjQqpt QIsL1JEU+ViDmWT0CbhrGoQqtOXj+/fphBDHas1Q9X9CEXUb84QBeUuf+7ipGyfv qN2E/S1Dl7gf05+N9Bf9OEYclJuanELYKE6P5YJ2VU0EFprjaBqg1NgxQEWwV1Td gkP4rbjW/4/XUWLRHt1a1s40FBc0a28C5aPWIC4dbNad3qbeYoqTgXygY/qud6Hj gldg054TIFDUZyV7TGoh =YNtd -----END PGP SIGNATURE----- --PHCdUe6m4AxPMzOu--