From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Reimplement "vFile:fstat" without qSupported
Date: Wed, 18 Mar 2015 11:25:00 -0000 [thread overview]
Message-ID: <20150318112514.GA2794@blade.nx> (raw)
In-Reply-To: <5509449D.2040705@redhat.com>
Pedro Alves wrote:
> On 03/17/2015 11:04 AM, Gary Benson wrote:
> > When I implemented the vFile:fstat packet the other week I didn't
> > understand how support for the other vFile packets was negotiated.
> > I implemented it using qSupported to indicate support, which means
> > the vFile:fstat packet is handled differently from all other vFile
> > packets--and for no good reason.
> >
> > This commit makes support for the vFile:fstat packet be determined
> > by probing rather than using qSupported. This makes it consistent
> > with all other vFile packets.
> >
> > Built and regtested on RHEL 6.6 x86_64.
> >
> > Ok to commit?
>
> OK.
Thanks Eli, Pedro, this is pushed now.
Cheers,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2015-03-18 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 11:04 Gary Benson
2015-03-17 11:09 ` Eli Zaretskii
2015-03-18 9:25 ` Pedro Alves
2015-03-18 11:25 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318112514.GA2794@blade.nx \
--to=gbenson@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox