From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110332 invoked by alias); 18 Mar 2015 11:25:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110321 invoked by uid 89); 18 Mar 2015 11:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Mar 2015 11:25:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2IBPGTK017530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Mar 2015 07:25:16 -0400 Received: from blade.nx (ovpn-116-79.ams2.redhat.com [10.36.116.79]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2IBPF1d004701; Wed, 18 Mar 2015 07:25:16 -0400 Received: by blade.nx (Postfix, from userid 1000) id DB8D9265073; Wed, 18 Mar 2015 11:25:14 +0000 (GMT) Date: Wed, 18 Mar 2015 11:25:00 -0000 From: Gary Benson To: Pedro Alves Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] Reimplement "vFile:fstat" without qSupported Message-ID: <20150318112514.GA2794@blade.nx> References: <1426590248-20310-1-git-send-email-gbenson@redhat.com> <5509449D.2040705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5509449D.2040705@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00541.txt.bz2 Pedro Alves wrote: > On 03/17/2015 11:04 AM, Gary Benson wrote: > > When I implemented the vFile:fstat packet the other week I didn't > > understand how support for the other vFile packets was negotiated. > > I implemented it using qSupported to indicate support, which means > > the vFile:fstat packet is handled differently from all other vFile > > packets--and for no good reason. > > > > This commit makes support for the vFile:fstat packet be determined > > by probing rather than using qSupported. This makes it consistent > > with all other vFile packets. > > > > Built and regtested on RHEL 6.6 x86_64. > > > > Ok to commit? > > OK. Thanks Eli, Pedro, this is pushed now. Cheers, Gary -- http://gbenson.net/