From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: arnez@linux.vnet.ibm.com (Andreas Arnez)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] S390: Defer PER info update until resume
Date: Tue, 10 Mar 2015 15:28:00 -0000 [thread overview]
Message-ID: <201503101527.t2AFRdMM023283@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <87385dgn3w.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Mar 10, 2015 11:31:31 AM
Andreas Arnez wrote:
> For multi-threaded inferiors on S390 GNU/Linux targets, GDB tried to
> update the PER info via ptrace() in a newly attached thread before
> assuring that the thread is stopped. Depending on the timing, this
> could lead to a GDB internal error. The patch defers the PER info
> update until just before resuming the thread.
>
> gdb/ChangeLog:
>
> * s390-linux-nat.c (struct arch_lwp_info): New.
> (s390_fix_watch_points): Rename to...
> (s390_prepare_to_resume): ...this. Skip the PER info update
> unless the watch points have changed.
> (s390_refresh_per_info, s390_new_thread): New functions.
> (s390_insert_watchpoint): Call s390_refresh_per_info instead of
> s390_fix_watch_points.
> (s390_remove_watchpoint): Likewise.
> (_initialize_s390_nat): Reflect renaming of s390_fix_watch_points.
> Register s390_prepare_to_resume.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2015-03-10 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 10:31 Andreas Arnez
2015-03-10 15:28 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503101527.t2AFRdMM023283@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox