From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81786 invoked by alias); 10 Mar 2015 15:28:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81770 invoked by uid 89); 10 Mar 2015 15:28:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp14.uk.ibm.com Received: from e06smtp14.uk.ibm.com (HELO e06smtp14.uk.ibm.com) (195.75.94.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 10 Mar 2015 15:28:02 +0000 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 10 Mar 2015 15:27:58 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 10 Mar 2015 15:27:56 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4F5EC219005E for ; Tue, 10 Mar 2015 15:27:47 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2AFRuhp9109938 for ; Tue, 10 Mar 2015 15:27:56 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2AFRo8F023549 for ; Tue, 10 Mar 2015 09:27:52 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t2AFRdMM023283; Tue, 10 Mar 2015 09:27:40 -0600 Message-Id: <201503101527.t2AFRdMM023283@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 10 Mar 2015 16:27:39 +0100 Subject: Re: [PATCH] S390: Defer PER info update until resume To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Tue, 10 Mar 2015 15:28:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <87385dgn3w.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Mar 10, 2015 11:31:31 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15031015-0017-0000-0000-00000351E38D X-SW-Source: 2015-03/txt/msg00248.txt.bz2 Andreas Arnez wrote: > For multi-threaded inferiors on S390 GNU/Linux targets, GDB tried to > update the PER info via ptrace() in a newly attached thread before > assuring that the thread is stopped. Depending on the timing, this > could lead to a GDB internal error. The patch defers the PER info > update until just before resuming the thread. > > gdb/ChangeLog: > > * s390-linux-nat.c (struct arch_lwp_info): New. > (s390_fix_watch_points): Rename to... > (s390_prepare_to_resume): ...this. Skip the PER info update > unless the watch points have changed. > (s390_refresh_per_info, s390_new_thread): New functions. > (s390_insert_watchpoint): Call s390_refresh_per_info instead of > s390_fix_watch_points. > (s390_remove_watchpoint): Likewise. > (_initialize_s390_nat): Reflect renaming of s390_fix_watch_points. > Register s390_prepare_to_resume. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com