From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: arnez@linux.vnet.ibm.com (Andreas Arnez)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] S390: Name "invisible" registers with the empty string instead of NULL
Date: Tue, 03 Mar 2015 16:15:00 -0000 [thread overview]
Message-ID: <201503031614.t23GEl5l003405@d03av02.boulder.ibm.com> (raw)
In-Reply-To: <87385mxdos.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Mar 03, 2015 05:12:35 PM
Andreas Arnez wrote:
> When adding vector register support to GDB, s390_register_name() was
> added to suppress the right halves of the first 16 vector registers.
> However, that function returned NULL instead of an empty string in such
> a case. This leads to an incomplete list of registers returned by
> "complete info registers ", because completion stops at the first NULL
> return value from user_reg_map_regnum_to_name().
>
> gdb/ChangeLog:
>
> * s390-linux-tdep.c (s390_register_name): Return empty string
> instead of NULL for registers that shouldn't be visible.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2015-03-03 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 16:12 Andreas Arnez
2015-03-03 16:15 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503031614.t23GEl5l003405@d03av02.boulder.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox