From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68493 invoked by alias); 3 Mar 2015 16:15:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66820 invoked by uid 89); 3 Mar 2015 16:15:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e37.co.us.ibm.com Received: from e37.co.us.ibm.com (HELO e37.co.us.ibm.com) (32.97.110.158) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Mar 2015 16:15:29 +0000 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2015 09:15:27 -0700 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 3 Mar 2015 09:15:25 -0700 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id E26383E40047 for ; Tue, 3 Mar 2015 09:15:23 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t23GDf6M23527548 for ; Tue, 3 Mar 2015 09:13:49 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t23GEnm5004614 for ; Tue, 3 Mar 2015 09:14:51 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t23GEl5l003405; Tue, 3 Mar 2015 09:14:47 -0700 Message-Id: <201503031614.t23GEl5l003405@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 03 Mar 2015 17:14:22 +0100 Subject: Re: [PATCH] S390: Name "invisible" registers with the empty string instead of NULL To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Tue, 03 Mar 2015 16:15:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <87385mxdos.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Mar 03, 2015 05:12:35 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15030316-0025-0000-0000-000009017D94 X-SW-Source: 2015-03/txt/msg00099.txt.bz2 Andreas Arnez wrote: > When adding vector register support to GDB, s390_register_name() was > added to suppress the right halves of the first 16 vector registers. > However, that function returned NULL instead of an empty string in such > a case. This leads to an incomplete list of registers returned by > "complete info registers ", because completion stops at the first NULL > return value from user_reg_map_regnum_to_name(). > > gdb/ChangeLog: > > * s390-linux-tdep.c (s390_register_name): Return empty string > instead of NULL for registers that shouldn't be visible. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com