From: Joel Brobecker <brobecker@adacore.com>
To: John Baldwin <jhb@freebsd.org>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: New ARI warning Fri Feb 27 01:54:21 UTC 2015
Date: Fri, 27 Feb 2015 08:24:00 -0000 [thread overview]
Message-ID: <20150227082442.GF31815@adacore.com> (raw)
In-Reply-To: <20150227015421.GA60225@sourceware.org>
Hello John,
I think you patch caused the following warnings. Could you take
a look and fix?
Also, while looking at the patch to confirm the source of the warnings,
I noticed curly braces on the same line as if conditions. Our coding
standard is to have them on the next line. Thus...
if (condition) {
[...]
}
... should be ...
if (condition)
{
[...]
}
Thank you!
On Fri, Feb 27, 2015 at 01:54:22AM +0000, GDB Administrator wrote:
> 16a17
> > gdb/amd64fbsd-tdep.c:54: code: OP eol: Do not use &&, or || at the end of a line
> gdb/amd64fbsd-tdep.c:54: if (memcmp (buf, amd64fbsd_sigtramp_code, sizeof amd64fbsd_sigtramp_code) !=
> 242a244,250
> > gdb/i386fbsd-tdep.c:108: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:108:gdb_static_assert (sizeof i386fbsd_sigtramp_start ==
> > gdb/i386fbsd-tdep.c:110: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:110:gdb_static_assert (sizeof i386fbsd_sigtramp_start ==
> > gdb/i386fbsd-tdep.c:112: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:112:gdb_static_assert (sizeof i386fbsd_sigtramp_middle ==
> > gdb/i386fbsd-tdep.c:114: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:114:gdb_static_assert (sizeof i386fbsd_sigtramp_middle ==
> > gdb/i386fbsd-tdep.c:116: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:116:gdb_static_assert (sizeof i386fbsd_sigtramp_end ==
> > gdb/i386fbsd-tdep.c:118: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:118:gdb_static_assert (sizeof i386fbsd_sigtramp_end ==
> > gdb/i386fbsd-tdep.c:138: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:138: if (memcmp (buf, i386fbsd_sigtramp_start, sizeof i386fbsd_sigtramp_start) ==
--
Joel
next prev parent reply other threads:[~2015-02-27 8:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 1:54 GDB Administrator
2015-02-27 8:24 ` Joel Brobecker [this message]
2015-02-27 19:01 ` John Baldwin
2015-03-02 15:02 ` Joel Brobecker
2015-03-12 19:37 ` John Baldwin
2015-03-13 17:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227082442.GF31815@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox