From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4467 invoked by alias); 27 Feb 2015 08:24:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4453 invoked by uid 89); 27 Feb 2015 08:24:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 27 Feb 2015 08:24:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5880D11674F; Fri, 27 Feb 2015 03:24:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i7h3DjOthfFc; Fri, 27 Feb 2015 03:24:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1B389116433; Fri, 27 Feb 2015 03:24:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 80FBD40EAD; Fri, 27 Feb 2015 09:24:42 +0100 (CET) Date: Fri, 27 Feb 2015 08:24:00 -0000 From: Joel Brobecker To: John Baldwin Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: New ARI warning Fri Feb 27 01:54:21 UTC 2015 Message-ID: <20150227082442.GF31815@adacore.com> References: <20150227015421.GA60225@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150227015421.GA60225@sourceware.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00802.txt.bz2 Hello John, I think you patch caused the following warnings. Could you take a look and fix? Also, while looking at the patch to confirm the source of the warnings, I noticed curly braces on the same line as if conditions. Our coding standard is to have them on the next line. Thus... if (condition) { [...] } ... should be ... if (condition) { [...] } Thank you! On Fri, Feb 27, 2015 at 01:54:22AM +0000, GDB Administrator wrote: > 16a17 > > gdb/amd64fbsd-tdep.c:54: code: OP eol: Do not use &&, or || at the end of a line > gdb/amd64fbsd-tdep.c:54: if (memcmp (buf, amd64fbsd_sigtramp_code, sizeof amd64fbsd_sigtramp_code) != > 242a244,250 > > gdb/i386fbsd-tdep.c:108: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:108:gdb_static_assert (sizeof i386fbsd_sigtramp_start == > > gdb/i386fbsd-tdep.c:110: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:110:gdb_static_assert (sizeof i386fbsd_sigtramp_start == > > gdb/i386fbsd-tdep.c:112: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:112:gdb_static_assert (sizeof i386fbsd_sigtramp_middle == > > gdb/i386fbsd-tdep.c:114: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:114:gdb_static_assert (sizeof i386fbsd_sigtramp_middle == > > gdb/i386fbsd-tdep.c:116: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:116:gdb_static_assert (sizeof i386fbsd_sigtramp_end == > > gdb/i386fbsd-tdep.c:118: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:118:gdb_static_assert (sizeof i386fbsd_sigtramp_end == > > gdb/i386fbsd-tdep.c:138: code: OP eol: Do not use &&, or || at the end of a line > gdb/i386fbsd-tdep.c:138: if (memcmp (buf, i386fbsd_sigtramp_start, sizeof i386fbsd_sigtramp_start) == -- Joel