Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: RFC: gdb-7.9-release tag on wrong commit (was: "Re: [release/branch] Set GDB version number to str 7.9.")
Date: Thu, 19 Feb 2015 12:40:00 -0000	[thread overview]
Message-ID: <20150219124010.GG23529@adacore.com> (raw)
In-Reply-To: <20150219122319.GF23529@adacore.com>

On Thu, Feb 19, 2015 at 04:23:19PM +0400, Joel Brobecker wrote:
> > In preparation for the GDB 7.9 release, I am about to push
> > this commit...
> > 
> > gdb/ChangeLog:
> > 
> > 	* version.in: Set GDB version number to str 7.9.
> [...]
> > diff --git a/gdb/version.in b/gdb/version.in
> > index 8c98182..2d982e4 100644
> > --- a/gdb/version.in
> > +++ b/gdb/version.in
> > @@ -1 +1 @@
> > -7.8.90.DATE-cvs
> > +str 7.9
> 
> For those who were actually paying attention (not me), there is
> an obvious mistake in the version number.
[...]
> But I was sleeping at the wheel. Fortunately, I caught it slightly
> later on. Attached is the patch that fixes the issue.

Humpf, I am realizing now that this was not soon enough:
I already pushed the gdb-7.9-release tag, and that tag
points to the first commit, and therefore has the wrong
version number in it.

The normal thing to do in those cases is to just accept the mistake
and create a new tag, tagging the correct commit. I find it so very
very ugly, but if I were to fix the tag, anyone having pulled from
sourceware would already have the "wrong" one, and would later on
have to delete the tag from their repository before they can get
the new one.

I'm not sure what to do:
  1. Create a new tag  (Eg: "gdb-7.9.0-release")
  2. Just re-do the tag (aka "the insane way")
  3. Leave things as is
  4. Abandon "7.9" and release "7.9.1" instead...

I am leaning towards option 4...

Thoughts?
-- 
Joel


  reply	other threads:[~2015-02-19 12:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 12:04 [release/branch] Set GDB version number to str 7.9 Joel Brobecker
2015-02-19 12:23 ` Joel Brobecker
2015-02-19 12:40   ` Joel Brobecker [this message]
2015-02-19 12:45     ` RFC: gdb-7.9-release tag on wrong commit (was: "Re: [release/branch] Set GDB version number to str 7.9.") Eli Zaretskii
2015-02-19 12:57       ` RFC: gdb-7.9-release tag on wrong commit Pedro Alves
2015-02-19 13:46         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219124010.GG23529@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox