From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 958 invoked by alias); 19 Feb 2015 12:40:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 943 invoked by uid 89); 19 Feb 2015 12:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 19 Feb 2015 12:40:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 13A41D2FD1 for ; Thu, 19 Feb 2015 07:40:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MfHXhdmJ0UGp for ; Thu, 19 Feb 2015 07:40:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A51D5D2FD0 for ; Thu, 19 Feb 2015 07:40:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C805940EAD; Thu, 19 Feb 2015 16:40:10 +0400 (RET) Date: Thu, 19 Feb 2015 12:40:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: RFC: gdb-7.9-release tag on wrong commit (was: "Re: [release/branch] Set GDB version number to str 7.9.") Message-ID: <20150219124010.GG23529@adacore.com> References: <1424347460-31023-1-git-send-email-brobecker@adacore.com> <20150219122319.GF23529@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150219122319.GF23529@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00533.txt.bz2 On Thu, Feb 19, 2015 at 04:23:19PM +0400, Joel Brobecker wrote: > > In preparation for the GDB 7.9 release, I am about to push > > this commit... > > > > gdb/ChangeLog: > > > > * version.in: Set GDB version number to str 7.9. > [...] > > diff --git a/gdb/version.in b/gdb/version.in > > index 8c98182..2d982e4 100644 > > --- a/gdb/version.in > > +++ b/gdb/version.in > > @@ -1 +1 @@ > > -7.8.90.DATE-cvs > > +str 7.9 > > For those who were actually paying attention (not me), there is > an obvious mistake in the version number. [...] > But I was sleeping at the wheel. Fortunately, I caught it slightly > later on. Attached is the patch that fixes the issue. Humpf, I am realizing now that this was not soon enough: I already pushed the gdb-7.9-release tag, and that tag points to the first commit, and therefore has the wrong version number in it. The normal thing to do in those cases is to just accept the mistake and create a new tag, tagging the correct commit. I find it so very very ugly, but if I were to fix the tag, anyone having pulled from sourceware would already have the "wrong" one, and would later on have to delete the tag from their repository before they can get the new one. I'm not sure what to do: 1. Create a new tag (Eg: "gdb-7.9.0-release") 2. Just re-do the tag (aka "the insane way") 3. Leave things as is 4. Abandon "7.9" and release "7.9.1" instead... I am leaning towards option 4... Thoughts? -- Joel