From: Joel Brobecker <brobecker@adacore.com>
To: Thomas Preud'homme <thomas.preudhomme@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
Date: Mon, 29 Dec 2014 12:09:00 -0000 [thread overview]
Message-ID: <20141229120924.GD2123@adacore.com> (raw)
In-Reply-To: <000301d02350$313224b0$93966e10$@arm.com>
> > Also, I don't think the cast to (int) are necessary, are they?
>
> Sigh. Indeed, they aren't. My apologize. I remember adding them after
> seeing an error but I cannot reproduce it. So either I compiled with
> g++ (why would I?) or the error came from something else in the patch
> which I changed as well. Should I post a patch to fix this or can I
> commit it as obvious?
No worries at all - if you had seen the number of brainless changes
I've pushed (and I am not calling your change brainless ;-)), you
would feel sorry for me.
You can commit that change as obvious, no problem. But, in case we
haven't said it before, even obvious changes need to be posted here,
with ChangeLog and all.
Thank you,
--
Joel
next prev parent reply other threads:[~2014-12-29 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 18:21 Thomas Preud'homme
2014-12-28 3:47 ` Joel Brobecker
2014-12-29 10:14 ` Thomas Preud'homme
2014-12-29 12:09 ` Joel Brobecker [this message]
2014-12-29 15:03 ` Thomas Preud'homme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229120924.GD2123@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=thomas.preudhomme@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox