From: "Thomas Preud'homme" <thomas.preudhomme@arm.com>
To: "'Joel Brobecker'" <brobecker@adacore.com>,
"Jiong Wang" <Jiong.Wang@arm.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [PATCH, ARM] Support for value 3 of Tag_ABI_VFP_args ARM attribute
Date: Mon, 29 Dec 2014 15:03:00 -0000 [thread overview]
Message-ID: <000501d02378$88b70d90$9a2528b0$@arm.com> (raw)
In-Reply-To: <20141229120924.GD2123@adacore.com>
> From: Joel Brobecker [mailto:brobecker@adacore.com]
> Sent: Monday, December 29, 2014 12:09 PM
>
> You can commit that change as obvious, no problem. But, in case we
> haven't said it before, even obvious changes need to be posted here,
> with ChangeLog and all.
>
Commited by courtesy of my colleague Jiong Wang.
ChangeLog entry is as follows:
*** gdb/ChangeLog ***
2014-12-29 Thomas Preud'homme thomas.preudhomme@arm.com
* arm-tdep.c (arm_gdbarch_init): Remove casts in Tag_ABI_VFP_args
switch case statements.
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index e12ae6e..dfec923 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -9968,25 +9968,25 @@ arm_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
OBJ_ATTR_PROC,
Tag_ABI_VFP_args))
{
- case (int) AEABI_VFP_args_base:
+ case AEABI_VFP_args_base:
/* "The user intended FP parameter/result
passing to conform to AAPCS, base
variant". */
fp_model = ARM_FLOAT_SOFT_VFP;
break;
- case (int) AEABI_VFP_args_vfp:
+ case AEABI_VFP_args_vfp:
/* "The user intended FP parameter/result
passing to conform to AAPCS, VFP
variant". */
fp_model = ARM_FLOAT_VFP;
break;
- case (int) AEABI_VFP_args_toolchain:
+ case AEABI_VFP_args_toolchain:
/* "The user intended FP parameter/result
passing to conform to tool chain-specific
conventions" - we don't know any such
conventions, so leave it as "auto". */
break;
- case (int) AEABI_VFP_args_compatible:
+ case AEABI_VFP_args_compatible:
/* "Code is compatible with both the base
and VFP variants; the user did not permit
non-variadic functions to pass FP
Best regards,
Thomas
prev parent reply other threads:[~2014-12-29 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 18:21 Thomas Preud'homme
2014-12-28 3:47 ` Joel Brobecker
2014-12-29 10:14 ` Thomas Preud'homme
2014-12-29 12:09 ` Joel Brobecker
2014-12-29 15:03 ` Thomas Preud'homme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501d02378$88b70d90$9a2528b0$@arm.com' \
--to=thomas.preudhomme@arm.com \
--cc=Jiong.Wang@arm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox