From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: David Taylor <dtaylor@emc.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PR 17520 -- structure offset wrong when 1/4 GB or greater
Date: Fri, 19 Dec 2014 12:40:00 -0000 [thread overview]
Message-ID: <20141219124055.GB12884@adacore.com> (raw)
In-Reply-To: <838ui4t3c3.fsf@gnu.org>
> I see you use %lld to print the 64-bit integer quantities, but I think
> you should use inttypes.h's PRId64 instead. At least MinGW32 use the
> Windows runtime, which doesn't understand %lld, AFAIK. And using
> inttypes.h's macros is more portable anyway.
That's a really good point.
Since these are LONGEST/ULONGEST, let's use plongest and pulongest
instead.
--
Joel
next prev parent reply other threads:[~2014-12-19 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 1:54 David Taylor
[not found] ` <838ui4t3c3.fsf@gnu.org>
2014-12-19 12:40 ` Joel Brobecker [this message]
2014-12-20 18:27 ` Joel Brobecker
2015-01-12 16:54 ` David Taylor
2015-01-13 9:31 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219124055.GB12884@adacore.com \
--to=brobecker@adacore.com \
--cc=dtaylor@emc.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox