From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20861 invoked by alias); 19 Dec 2014 12:40:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20848 invoked by uid 89); 19 Dec 2014 12:40:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 19 Dec 2014 12:40:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B86B11164DA; Fri, 19 Dec 2014 07:40:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n5mn5bAoqw4j; Fri, 19 Dec 2014 07:40:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9E8B41164CF; Fri, 19 Dec 2014 07:40:55 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C77AD40166; Fri, 19 Dec 2014 07:40:55 -0500 (EST) Date: Fri, 19 Dec 2014 12:40:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: David Taylor , gdb-patches@sourceware.org Subject: Re: [PATCH] PR 17520 -- structure offset wrong when 1/4 GB or greater Message-ID: <20141219124055.GB12884@adacore.com> References: <1418954030-16797-1-git-send-email-dtaylor@emc.com> <838ui4t3c3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838ui4t3c3.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00576.txt.bz2 > I see you use %lld to print the 64-bit integer quantities, but I think > you should use inttypes.h's PRId64 instead. At least MinGW32 use the > Windows runtime, which doesn't understand %lld, AFAIK. And using > inttypes.h's macros is more portable anyway. That's a really good point. Since these are LONGEST/ULONGEST, let's use plongest and pulongest instead. -- Joel