From: Joel Brobecker <brobecker@adacore.com>
To: David Taylor <dtaylor@usendtaylorx2l.lss.emc.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFA 1/2 fix for bug with large structure offsets
Date: Mon, 15 Dec 2014 15:21:00 -0000 [thread overview]
Message-ID: <20141215152111.GZ5457@adacore.com> (raw)
In-Reply-To: <22812.1418656160@usendtaylorx2l>
> > resubmit them with a proper description of the problem they fix and
> > a ChangeLog entry? Please Cc: me and I will review them next weekend.
>
> Is the description and ChangeLog in part 0 insufficient?
>
> There were three parts --
>
> 0/2 -- description of the problem and ChangeLog entries
> 1/2 -- changes to GDB proper
> 2/2 -- testsuite changes (basically, a really simple test)
The introduction email is good sometimes, but now try to include
all the necessary info to explain what the patch does in the
commit's revision log. There are two advantages to this:
1. It makes archeology a lot easier, since the information
is right there;
2. It makes it easier for you to contribute the patch, since
all you have to do is git-email it.
Introduction emails are useful sometimes when you want to provide
some general context that doesn't really belong in the revision
log of any of the patches. The idea is that we should be able to
have all necessary info for a given commit just by looking at
that commit.
Remember to Cc: me when you resubmit - it'll help me remember
I promised to review your patches this weekend.
--
Joel
prev parent reply other threads:[~2014-12-15 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 16:53 David Taylor
2014-12-13 13:22 ` Joel Brobecker
2014-12-15 15:09 ` David Taylor
2014-12-15 15:21 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215152111.GZ5457@adacore.com \
--to=brobecker@adacore.com \
--cc=dtaylor@usendtaylorx2l.lss.emc.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox