From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2084 invoked by alias); 15 Dec 2014 15:21:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2071 invoked by uid 89); 15 Dec 2014 15:21:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Dec 2014 15:21:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 435BA116523 for ; Mon, 15 Dec 2014 10:21:11 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RqZfvrjxHsu6 for ; Mon, 15 Dec 2014 10:21:11 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 28B3E1163F1 for ; Mon, 15 Dec 2014 10:21:11 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 79DCC40164; Mon, 15 Dec 2014 10:21:11 -0500 (EST) Date: Mon, 15 Dec 2014 15:21:00 -0000 From: Joel Brobecker To: David Taylor Cc: "gdb-patches@sourceware.org" Subject: Re: RFA 1/2 fix for bug with large structure offsets Message-ID: <20141215152111.GZ5457@adacore.com> References: <18839.1416329575@usendtaylorx2l> <20141213132225.GC5457@adacore.com> <22812.1418656160@usendtaylorx2l> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22812.1418656160@usendtaylorx2l> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00393.txt.bz2 > > resubmit them with a proper description of the problem they fix and > > a ChangeLog entry? Please Cc: me and I will review them next weekend. > > Is the description and ChangeLog in part 0 insufficient? > > There were three parts -- > > 0/2 -- description of the problem and ChangeLog entries > 1/2 -- changes to GDB proper > 2/2 -- testsuite changes (basically, a really simple test) The introduction email is good sometimes, but now try to include all the necessary info to explain what the patch does in the commit's revision log. There are two advantages to this: 1. It makes archeology a lot easier, since the information is right there; 2. It makes it easier for you to contribute the patch, since all you have to do is git-email it. Introduction emails are useful sometimes when you want to provide some general context that doesn't really belong in the revision log of any of the patches. The idea is that we should be able to have all necessary info for a given commit just by looking at that commit. Remember to Cc: me when you resubmit - it'll help me remember I promised to review your patches this weekend. -- Joel