From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: gdb-patches@sourceware.org, davem@redhat.com
Subject: Re: [RFC/RFT] Use core regset iterators on Sparc Solaris
Date: Wed, 03 Dec 2014 14:42:00 -0000 [thread overview]
Message-ID: <201412031442.sB3EgOgn022198@d03av02.boulder.ibm.com> (raw)
In-Reply-To: <20141203132338.GC7899@adacore.com> from "Joel Brobecker" at Dec 03, 2014 05:23:38 PM
Joel Brobecker wrote:
> > gdb/
> > * config/sparc/sol2.mh (NATDEPFILES): Remove core-regset.o.
> > * sparc-sol2-tdep.c: Include "regset.h".
> > (sparc32_sol2_supply_core_gregset): New function.
> > (sparc32_sol2_collect_core_gregset): Likewise.
> > (sparc32_sol2_supply_core_fpregset): Likewise.
> > (sparc32_sol2_collect_core_fpregset): Likewise.
> > (sparc32_sol2_gregset, sparc32_sol2_fpregset): New variables.
> > (sparc32_sol2_init_abi): Set tdep->gregset/sizeof_gregset and
> > tdep->fpregset/sizeof_fpregset.
> > * sparc64-sol2-tdep.c: Include "regset.h".
> > (sparc64_sol2_supply_core_gregset): New function.
> > (sparc64_sol2_collect_core_gregset): Likewise.
> > (sparc64_sol2_supply_core_fpregset): Likewise.
> > (sparc64_sol2_collect_core_fpregset): Likewise.
> > (sparc64_sol2_gregset, sparc64_sol2_fpregset): New variables.
> > (sparc64_sol2_init_abi): Set tdep->gregset/sizeof_gregset and
> > tdep->fpregset/sizeof_fpregset.
>
> I tested this patch on sparc-solaris using AdaCore's testsuite,
> and it revealed no regression, and in particular testcases involving
> the use of core files continued passing.
Excellent! Many thanks for testing!
I've now pushed this patch.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2014-12-03 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 15:48 Ulrich Weigand
2014-12-03 4:01 ` Joel Brobecker
2014-12-03 13:23 ` Joel Brobecker
2014-12-03 14:42 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412031442.sB3EgOgn022198@d03av02.boulder.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=davem@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox