From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1569 invoked by alias); 3 Dec 2014 14:42:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1533 invoked by uid 89); 3 Dec 2014 14:42:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e35.co.us.ibm.com Received: from e35.co.us.ibm.com (HELO e35.co.us.ibm.com) (32.97.110.153) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 14:42:32 +0000 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Dec 2014 07:42:30 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 3 Dec 2014 07:42:28 -0700 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 9B36E19D803E for ; Wed, 3 Dec 2014 07:31:07 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sB3Egsud42729636 for ; Wed, 3 Dec 2014 07:42:54 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sB3EgQLi022398 for ; Wed, 3 Dec 2014 07:42:26 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id sB3EgOgn022198; Wed, 3 Dec 2014 07:42:24 -0700 Message-Id: <201412031442.sB3EgOgn022198@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 03 Dec 2014 15:42:23 +0100 Subject: Re: [RFC/RFT] Use core regset iterators on Sparc Solaris To: brobecker@adacore.com (Joel Brobecker) Date: Wed, 03 Dec 2014 14:42:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, davem@redhat.com In-Reply-To: <20141203132338.GC7899@adacore.com> from "Joel Brobecker" at Dec 03, 2014 05:23:38 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14120314-0013-0000-0000-000006B9F67A X-SW-Source: 2014-12/txt/msg00062.txt.bz2 Joel Brobecker wrote: > > gdb/ > > * config/sparc/sol2.mh (NATDEPFILES): Remove core-regset.o. > > * sparc-sol2-tdep.c: Include "regset.h". > > (sparc32_sol2_supply_core_gregset): New function. > > (sparc32_sol2_collect_core_gregset): Likewise. > > (sparc32_sol2_supply_core_fpregset): Likewise. > > (sparc32_sol2_collect_core_fpregset): Likewise. > > (sparc32_sol2_gregset, sparc32_sol2_fpregset): New variables. > > (sparc32_sol2_init_abi): Set tdep->gregset/sizeof_gregset and > > tdep->fpregset/sizeof_fpregset. > > * sparc64-sol2-tdep.c: Include "regset.h". > > (sparc64_sol2_supply_core_gregset): New function. > > (sparc64_sol2_collect_core_gregset): Likewise. > > (sparc64_sol2_supply_core_fpregset): Likewise. > > (sparc64_sol2_collect_core_fpregset): Likewise. > > (sparc64_sol2_gregset, sparc64_sol2_fpregset): New variables. > > (sparc64_sol2_init_abi): Set tdep->gregset/sizeof_gregset and > > tdep->fpregset/sizeof_fpregset. > > I tested this patch on sparc-solaris using AdaCore's testsuite, > and it revealed no regression, and in particular testcases involving > the use of core files continued passing. Excellent! Many thanks for testing! I've now pushed this patch. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com