From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] Import readlink
Date: Wed, 03 Dec 2014 10:48:00 -0000 [thread overview]
Message-ID: <20141203104812.GA14666@adacore.com> (raw)
In-Reply-To: <1416980800-21408-2-git-send-email-yao@codesourcery.com>
> 2014-11-26 Yao Qi <yao@codesourcery.com>
>
> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add readlink.
> * gnulib/aclocal.m4: Re-generated.
> * gnulib/config.in: Likewise.
> * gnulib/configure: Likewise.
> * gnulib/import/Makefile.am: Likewise.
> * gnulib/import/Makefile.in: Likewise.
> * gnulib/import/m4/gnulib-cache.m4: Likewise.
> * gnulib/import/m4/gnulib-comp.m4: Likewise.
> * gnulib/import/dosname.h: New file
> * gnulib/import/m4/largefile.m4: New file.
> * gnulib/import/m4/readlink.m4: New file.
> * gnulib/import/m4/stat.m4: New file.
> * gnulib/import/readlink.c: New file.
> * gnulib/import/stat.c: New file.
FTR, I think this patch is reponsible for GDB failing to build
on 32bit Solaris systems (Sparc and x86), due to the introduction
of the following #define in gnulib's config.in:
> +/* Number of bits in a file offset, on hosts where this is settable. */
> +#undef _FILE_OFFSET_BITS
When defined to 64, it triggers an issue with procfs.h:
#if !defined(_LP64) && _FILE_OFFSET_BITS == 64
#error "Cannot use procfs in the large file compilation environment"
#endif
This is utterly familiar, but I just can't remember what the problem
was, at the time, nor what I did. I will research it next.
--
Joel
next prev parent reply other threads:[~2014-12-03 10:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 5:46 [PATCH 0/7 V2] Import the rename gnulib module Yao Qi
2014-11-26 5:46 ` [PATCH 2/7] Use readlink unconditionally Yao Qi
2014-11-26 5:46 ` [PATCH 1/7] Import readlink Yao Qi
2014-12-03 10:48 ` Joel Brobecker [this message]
2014-12-03 12:08 ` [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled Joel Brobecker
2014-12-03 17:59 ` Eli Zaretskii
2014-12-04 3:18 ` Joel Brobecker
2014-12-04 6:47 ` Eli Zaretskii
2014-12-13 16:29 ` Joel Brobecker
2014-12-04 2:17 ` Yao Qi
2014-12-13 14:46 ` pushed: " Joel Brobecker
2014-11-26 5:47 ` [PATCH 6/7] Use canonicalize_file_name unconditionally Yao Qi
2014-11-27 7:36 ` Joel Brobecker
2014-11-28 3:07 ` Yao Qi
2014-11-28 3:43 ` Joel Brobecker
2014-11-28 10:43 ` Yao Qi
2014-11-28 14:46 ` Joel Brobecker
2014-11-26 5:47 ` [PATCH 5/7] Import canonicalize-lgpl Yao Qi
2014-11-26 5:47 ` [PATCH 3/7] Import lstat Yao Qi
2014-12-02 17:01 ` Joel Brobecker
2014-12-03 9:48 ` [pushed] callback.h:struct host_callback_struct compilation error on Windows hosts Joel Brobecker
2014-12-04 1:09 ` Yao Qi
2014-12-04 5:42 ` Joel Brobecker
2014-11-26 5:47 ` [PATCH 4/7] Use lstat unconditionally Yao Qi
2014-11-26 5:47 ` [PATCH 7/7] Import rename module Yao Qi
2014-11-26 15:40 ` [PATCH 0/7 V2] Import the rename gnulib module Eli Zaretskii
2014-11-27 3:48 ` Yao Qi
2014-11-27 7:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203104812.GA14666@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox