From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6680 invoked by alias); 3 Dec 2014 10:48:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6665 invoked by uid 89); 3 Dec 2014 10:48:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 10:48:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 33E11116895; Wed, 3 Dec 2014 05:48:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id quf1wvvwrUZF; Wed, 3 Dec 2014 05:48:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CDA46116891; Wed, 3 Dec 2014 05:48:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A766A46B66; Wed, 3 Dec 2014 14:48:12 +0400 (RET) Date: Wed, 03 Dec 2014 10:48:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] Import readlink Message-ID: <20141203104812.GA14666@adacore.com> References: <1416980800-21408-1-git-send-email-yao@codesourcery.com> <1416980800-21408-2-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416980800-21408-2-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00057.txt.bz2 > 2014-11-26 Yao Qi > > * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add readlink. > * gnulib/aclocal.m4: Re-generated. > * gnulib/config.in: Likewise. > * gnulib/configure: Likewise. > * gnulib/import/Makefile.am: Likewise. > * gnulib/import/Makefile.in: Likewise. > * gnulib/import/m4/gnulib-cache.m4: Likewise. > * gnulib/import/m4/gnulib-comp.m4: Likewise. > * gnulib/import/dosname.h: New file > * gnulib/import/m4/largefile.m4: New file. > * gnulib/import/m4/readlink.m4: New file. > * gnulib/import/m4/stat.m4: New file. > * gnulib/import/readlink.c: New file. > * gnulib/import/stat.c: New file. FTR, I think this patch is reponsible for GDB failing to build on 32bit Solaris systems (Sparc and x86), due to the introduction of the following #define in gnulib's config.in: > +/* Number of bits in a file offset, on hosts where this is settable. */ > +#undef _FILE_OFFSET_BITS When defined to 64, it triggers an issue with procfs.h: #if !defined(_LP64) && _FILE_OFFSET_BITS == 64 #error "Cannot use procfs in the large file compilation environment" #endif This is utterly familiar, but I just can't remember what the problem was, at the time, nor what I did. I will research it next. -- Joel