From: Joel Brobecker <brobecker@adacore.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: gdb-patches@sourceware.org, cleber@redhat.com
Subject: Re: [PATCH 2/2] Function attributes: use shorter versions of the format macros
Date: Wed, 03 Dec 2014 10:31:00 -0000 [thread overview]
Message-ID: <20141203103111.GB7899@adacore.com> (raw)
In-Reply-To: <1417449499-23681-2-git-send-email-crosa@redhat.com>
> For consistency sake, use the shorter versions of the function attribute
> format macros.
Same as in patch #1, please include the ChangeLog entry in the
commit's revision log.
It would be good also to explain in the revision log consistency
with what, becuase GDB uses nearly exclusively the form that you
are removing. I know the answer, now, but it took me some time to
figure it out.
> +2014-12-01 Cleber Rosa <cleber@redhat.com>
> +
> + * ada-lang.c: use shorter versions of function attributes macros.
> + * cli-out.c: Likewise.
> + * common/agent.c: Likewise.
> + * common/buffer.h: Likewise.
> + * common/common-debug.h: Likewise.
> + * common/common-exceptions.h: Likewise.
> + * common/common-utils.h: Likewise.
> + * common/errors.h: Likewise.
> + * complaints.h: Likewise.
> + * disasm.c: Likewise.
> + * exceptions.h: Likewise.
> + * language.h: Likewise.
> + * monitor.c: Likewise.
> + * parser-defs.h: Likewise.
> + * serial.h: Likewise.
> + * ui-out.h: Likewise.
> + * utils.h: Likewise.
Approved.
Thank you,
--
Joel
next prev parent reply other threads:[~2014-12-03 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 15:58 [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog Cleber Rosa
2014-12-01 15:58 ` [PATCH 2/2] Function attributes: use shorter versions of the format macros Cleber Rosa
2014-12-01 20:39 ` Sergio Durigan Junior
2014-12-03 10:31 ` Joel Brobecker [this message]
2014-12-04 13:29 ` Cleber Rosa
2014-12-11 18:51 ` [v2,1/2] remote-utils.c: remove unused gdb_stdlog Cleber Rosa
2014-12-11 18:51 ` [v2,2/2] Function attributes: use shorter versions of the format macros Cleber Rosa
2014-12-12 11:51 ` Pedro Alves
2014-12-13 16:21 ` Cleber Rosa
2014-12-01 20:34 ` [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog Sergio Durigan Junior
2014-12-03 10:12 ` Joel Brobecker
2014-12-04 16:49 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203103111.GB7899@adacore.com \
--to=brobecker@adacore.com \
--cc=cleber@redhat.com \
--cc=crosa@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox