From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24482 invoked by alias); 3 Dec 2014 10:31:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24423 invoked by uid 89); 3 Dec 2014 10:31:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 03 Dec 2014 10:31:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A434211678B; Wed, 3 Dec 2014 05:31:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NtFGZmJfXGIk; Wed, 3 Dec 2014 05:31:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 49F97116789; Wed, 3 Dec 2014 05:31:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 41D6846B66; Wed, 3 Dec 2014 14:31:11 +0400 (RET) Date: Wed, 03 Dec 2014 10:31:00 -0000 From: Joel Brobecker To: Cleber Rosa Cc: gdb-patches@sourceware.org, cleber@redhat.com Subject: Re: [PATCH 2/2] Function attributes: use shorter versions of the format macros Message-ID: <20141203103111.GB7899@adacore.com> References: <1417449499-23681-1-git-send-email-crosa@redhat.com> <1417449499-23681-2-git-send-email-crosa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417449499-23681-2-git-send-email-crosa@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00056.txt.bz2 > For consistency sake, use the shorter versions of the function attribute > format macros. Same as in patch #1, please include the ChangeLog entry in the commit's revision log. It would be good also to explain in the revision log consistency with what, becuase GDB uses nearly exclusively the form that you are removing. I know the answer, now, but it took me some time to figure it out. > +2014-12-01 Cleber Rosa > + > + * ada-lang.c: use shorter versions of function attributes macros. > + * cli-out.c: Likewise. > + * common/agent.c: Likewise. > + * common/buffer.h: Likewise. > + * common/common-debug.h: Likewise. > + * common/common-exceptions.h: Likewise. > + * common/common-utils.h: Likewise. > + * common/errors.h: Likewise. > + * complaints.h: Likewise. > + * disasm.c: Likewise. > + * exceptions.h: Likewise. > + * language.h: Likewise. > + * monitor.c: Likewise. > + * parser-defs.h: Likewise. > + * serial.h: Likewise. > + * ui-out.h: Likewise. > + * utils.h: Likewise. Approved. Thank you, -- Joel