Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: gdb-patches@sourceware.org, Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue
Date: Sun, 23 Nov 2014 06:38:00 -0000	[thread overview]
Message-ID: <20141123063849.GA7636@adacore.com> (raw)
In-Reply-To: <544AD714.8040506@gmail.com>

Chen,

> Is this patch OK, it is part of checking saving registers in the stack,
> it tries to recognize the saving instructions "stb, stw(m), or std", so
> can continue checking.
> 
> Excuse me, I have no related environments for a test, I assumed that the
> original author knew about the working flow, then wrote the related
> function.
> 
> If need additional analyzing, please let me know (better to let me know
> what I need try, next).

Thank you for the patch, but lack of access to an environment where
you can test is an issue.  I would be an entirely different context
if the fix was obvious, but it isn't unless perhaps you start
opening HP-PA assembly manuals; and I don't honestly see much interest
in HP-PA anymore.

And if you do not have access to an environment for a test, how did
you come about this issue? Does the lack of evironment mean lack of
the software (tcl, expect, dejagnu), or lack of hardware?

-- 
Joel


  reply	other threads:[~2014-11-23  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 15:39 Chen Gang
2014-10-22 15:41 ` Chen Gang
2014-10-24 22:41 ` Chen Gang
2014-11-23  6:38   ` Joel Brobecker [this message]
2014-11-23 13:40     ` Chen Gang
2014-12-07 22:31       ` Chen Gang
2014-12-08  3:15         ` Joel Brobecker
2014-12-08  4:20           ` Chen Gang
2014-12-08  5:08             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141123063849.GA7636@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox