From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20542 invoked by alias); 23 Nov 2014 06:38:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20531 invoked by uid 89); 23 Nov 2014 06:38:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 23 Nov 2014 06:38:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B6A181166FF; Sun, 23 Nov 2014 01:38:50 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CiGpmFNhsnIl; Sun, 23 Nov 2014 01:38:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3704C1166FE; Sun, 23 Nov 2014 01:38:50 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 75C1440F79; Sun, 23 Nov 2014 10:38:49 +0400 (RET) Date: Sun, 23 Nov 2014 06:38:00 -0000 From: Joel Brobecker To: Chen Gang Cc: gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue Message-ID: <20141123063849.GA7636@adacore.com> References: <5447CF8A.6020603@gmail.com> <544AD714.8040506@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <544AD714.8040506@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00553.txt.bz2 Chen, > Is this patch OK, it is part of checking saving registers in the stack, > it tries to recognize the saving instructions "stb, stw(m), or std", so > can continue checking. > > Excuse me, I have no related environments for a test, I assumed that the > original author knew about the working flow, then wrote the related > function. > > If need additional analyzing, please let me know (better to let me know > what I need try, next). Thank you for the patch, but lack of access to an environment where you can test is an issue. I would be an entirely different context if the fix was obvious, but it isn't unless perhaps you start opening HP-PA assembly manuals; and I don't honestly see much interest in HP-PA anymore. And if you do not have access to an environment for a test, how did you come about this issue? Does the lack of evironment mean lack of the software (tcl, expect, dejagnu), or lack of hardware? -- Joel