From: Joel Brobecker <brobecker@adacore.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: palves@redhat.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix MPX and AVX512 tests for path changes.
Date: Sun, 23 Nov 2014 03:42:00 -0000 [thread overview]
Message-ID: <20141123034212.GB5774@adacore.com> (raw)
In-Reply-To: <1412062097-22417-1-git-send-email-walfred.tedeschi@intel.com>
Hello Walfred,
On Tue, Sep 30, 2014 at 09:28:17AM +0200, Walfred Tedeschi wrote:
> Changes on the path for i386-cpuid.h file lead to failure in compiling
> tests for MPX and AVX512. Conformity between both tests is also
> addressed with this path.
>
> 2014-08-12 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> gdb/testsuite
> * gdb.arch/i386-avx512.c: Change path in include file.
> * gdb.arch/i386-mpx.c: Change path in include file.
> * gdb.arch/i386-avx512.exp: Change include dir path
> compilation flag.
> * gdb.arch/i386-mpx.exp: Change include dir path
> compilation flag.
Overall, the changes look good. But would you mind please splitting
this patch into individual pieces. For instance, one patch to fix
i386-avx512.exp's build failure, one patch to fix i386-mpx.exp's
build failure, and then as many individual patches for the other
changes made for "conformity between both tests". I am 300 patches
behind on review and trying to spend this weekend catching up a bit,
so a more detailed explanation will help me, as well as anyone
going back in time trying to figure out why some changes were made.
Thank you!
--
Joel
next prev parent reply other threads:[~2014-11-23 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 7:28 Walfred Tedeschi
2014-11-23 3:42 ` Joel Brobecker [this message]
2014-11-24 13:48 ` Tedeschi, Walfred
2014-11-24 14:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141123034212.GB5774@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox