From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25134 invoked by alias); 23 Nov 2014 03:42:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25054 invoked by uid 89); 23 Nov 2014 03:42:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 23 Nov 2014 03:42:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8BFFE1166B6; Sat, 22 Nov 2014 22:42:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lQ-rwjR+u8vA; Sat, 22 Nov 2014 22:42:13 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id ED18C11662B; Sat, 22 Nov 2014 22:42:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3EB3140F79; Sun, 23 Nov 2014 07:42:12 +0400 (RET) Date: Sun, 23 Nov 2014 03:42:00 -0000 From: Joel Brobecker To: Walfred Tedeschi Cc: palves@redhat.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix MPX and AVX512 tests for path changes. Message-ID: <20141123034212.GB5774@adacore.com> References: <1412062097-22417-1-git-send-email-walfred.tedeschi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1412062097-22417-1-git-send-email-walfred.tedeschi@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00549.txt.bz2 Hello Walfred, On Tue, Sep 30, 2014 at 09:28:17AM +0200, Walfred Tedeschi wrote: > Changes on the path for i386-cpuid.h file lead to failure in compiling > tests for MPX and AVX512. Conformity between both tests is also > addressed with this path. > > 2014-08-12 Walfred Tedeschi > > gdb/testsuite > * gdb.arch/i386-avx512.c: Change path in include file. > * gdb.arch/i386-mpx.c: Change path in include file. > * gdb.arch/i386-avx512.exp: Change include dir path > compilation flag. > * gdb.arch/i386-mpx.exp: Change include dir path > compilation flag. Overall, the changes look good. But would you mind please splitting this patch into individual pieces. For instance, one patch to fix i386-avx512.exp's build failure, one patch to fix i386-mpx.exp's build failure, and then as many individual patches for the other changes made for "conformity between both tests". I am 300 patches behind on review and trying to spend this weekend catching up a bit, so a more detailed explanation will help me, as well as anyone going back in time trying to figure out why some changes were made. Thank you! -- Joel