From: Joel Brobecker <brobecker@adacore.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH] microMIPS support (Linux signal trampolines)
Date: Sun, 16 Nov 2014 08:58:00 -0000 [thread overview]
Message-ID: <20141116085801.GA8336@adacore.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1409280051430.4971@tp.orcam.me.uk>
> I'd like to get back to this change and review. Here's the same code
> regenerated against current trunk. Can we please get consensus on changes
> to tramp-frame.[ch]?
[...]
> 2014-09-28 Maciej W. Rozycki <macro@codesourcery.com>
>
> gdb/
> * tramp-frame.h (tramp_frame): Add validate member.
> * tramp-frame.c (tramp_frame_start): Validate trampoline before
> scanning.
> * mips-linux-tdep.c (MICROMIPS_INST_LI_V0): New macro.
> (MICROMIPS_INST_POOL32A, MICROMIPS_INST_SYSCALL): Likewise.
> (mips_linux_o32_sigframe): Initialize validate member.
> (mips_linux_o32_rt_sigframe): Likewise.
> (mips_linux_n32_rt_sigframe): Likewise.
> (mips_linux_n64_rt_sigframe): Likewise.
> (micromips_linux_o32_sigframe): New variable.
> (micromips_linux_o32_rt_sigframe): Likewise.
> (micromips_linux_n32_rt_sigframe): Likewise.
> (micromips_linux_n64_rt_sigframe): Likewise.
> (mips_linux_o32_sigframe_init): Handle microMIPS trampolines.
> (mips_linux_n32n64_sigframe_init): Likewise.
> (mips_linux_sigframe_validate): New function.
> (micromips_linux_sigframe_validate): Likewise.
> (mips_linux_init_abi): Install microMIPS trampoline unwinders.
Sorry again for the late review, Maciej.
This patch is pre-approved, with one tiny little request:
Can you add a quick one-liner comment as documentation for
all the new functions? For instance:
/* Implement struct tramp_frame's "validate" method for [...] */
static int
mips_linux_sigframe_validate (const struct tramp_frame *self,
Thank you!
--
Joel
next prev parent reply other threads:[~2014-11-16 8:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 21:18 [PATCH] microMIPS support Maciej W. Rozycki
2012-04-25 6:20 ` Eli Zaretskii
2012-04-26 13:54 ` Maciej W. Rozycki
2012-04-26 14:14 ` Eli Zaretskii
2012-04-26 18:03 ` Maciej W. Rozycki
2012-04-26 20:39 ` Eli Zaretskii
2012-04-27 18:16 ` Maciej W. Rozycki
2012-04-27 18:24 ` Eli Zaretskii
[not found] ` <alpine.DEB.1.10.1204302334520.19835@tp.orcam.me.uk>
2012-05-02 16:39 ` Eli Zaretskii
2012-05-17 15:07 ` Maciej W. Rozycki
2012-05-17 16:10 ` Eli Zaretskii
2012-05-18 23:13 ` Maciej W. Rozycki
2012-05-19 8:20 ` Eli Zaretskii
2012-04-25 13:13 ` Yao Qi
2012-04-25 15:57 ` Maciej W. Rozycki
2012-04-25 15:54 ` Joel Brobecker
2012-04-25 17:18 ` Maciej W. Rozycki
2012-04-25 18:12 ` Joel Brobecker
2012-04-25 18:27 ` Maciej W. Rozycki
2012-04-26 18:38 ` Jan Kratochvil
2012-04-26 19:04 ` Maciej W. Rozycki
2012-04-26 19:29 ` Jan Kratochvil
2012-04-26 21:59 ` Maciej W. Rozycki
2012-04-27 7:11 ` Jan Kratochvil
2012-04-27 15:14 ` Maciej W. Rozycki
2012-04-27 15:29 ` Pedro Alves
2012-04-27 15:46 ` Maciej W. Rozycki
2012-04-27 15:54 ` Tom Tromey
2012-05-18 23:53 ` Maciej W. Rozycki
2012-05-18 21:32 ` [PATCH] microMIPS support (Linux signal trampolines) Maciej W. Rozycki
2012-05-18 22:25 ` Mark Kettenis
2012-05-21 14:33 ` Maciej W. Rozycki
2012-06-11 10:32 ` [PING][PATCH] " Maciej W. Rozycki
2014-09-28 11:12 ` [PATCH] " Maciej W. Rozycki
2014-10-06 0:46 ` [PING][PATCH] " Maciej W. Rozycki
2014-10-13 12:24 ` [PING^2][PATCH] " Maciej W. Rozycki
2014-10-20 17:01 ` [PING^3][PATCH] " Maciej W. Rozycki
2014-11-03 16:04 ` [PING^4][PATCH] " Maciej W. Rozycki
2014-11-16 8:58 ` Joel Brobecker [this message]
2014-12-03 21:00 ` [PATCH] " Maciej W. Rozycki
2012-05-18 23:47 ` [PATCH] microMIPS support Maciej W. Rozycki
2012-05-19 8:52 ` Eli Zaretskii
2012-05-22 0:07 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141116085801.GA8336@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox