From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23940 invoked by alias); 16 Nov 2014 08:58:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23921 invoked by uid 89); 16 Nov 2014 08:58:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 16 Nov 2014 08:58:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3DD7D1166F8; Sun, 16 Nov 2014 03:58:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MGyvJ+iC-coY; Sun, 16 Nov 2014 03:58:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AC39A1165A2; Sun, 16 Nov 2014 03:58:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E495740F79; Sun, 16 Nov 2014 12:58:01 +0400 (RET) Date: Sun, 16 Nov 2014 08:58:00 -0000 From: Joel Brobecker To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [PATCH] microMIPS support (Linux signal trampolines) Message-ID: <20141116085801.GA8336@adacore.com> References: <201205182225.q4IMPBiD031110@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00375.txt.bz2 > I'd like to get back to this change and review. Here's the same code > regenerated against current trunk. Can we please get consensus on changes > to tramp-frame.[ch]? [...] > 2014-09-28 Maciej W. Rozycki > > gdb/ > * tramp-frame.h (tramp_frame): Add validate member. > * tramp-frame.c (tramp_frame_start): Validate trampoline before > scanning. > * mips-linux-tdep.c (MICROMIPS_INST_LI_V0): New macro. > (MICROMIPS_INST_POOL32A, MICROMIPS_INST_SYSCALL): Likewise. > (mips_linux_o32_sigframe): Initialize validate member. > (mips_linux_o32_rt_sigframe): Likewise. > (mips_linux_n32_rt_sigframe): Likewise. > (mips_linux_n64_rt_sigframe): Likewise. > (micromips_linux_o32_sigframe): New variable. > (micromips_linux_o32_rt_sigframe): Likewise. > (micromips_linux_n32_rt_sigframe): Likewise. > (micromips_linux_n64_rt_sigframe): Likewise. > (mips_linux_o32_sigframe_init): Handle microMIPS trampolines. > (mips_linux_n32n64_sigframe_init): Likewise. > (mips_linux_sigframe_validate): New function. > (micromips_linux_sigframe_validate): Likewise. > (mips_linux_init_abi): Install microMIPS trampoline unwinders. Sorry again for the late review, Maciej. This patch is pre-approved, with one tiny little request: Can you add a quick one-liner comment as documentation for all the new functions? For instance: /* Implement struct tramp_frame's "validate" method for [...] */ static int mips_linux_sigframe_validate (const struct tramp_frame *self, Thank you! -- Joel