From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: amodra@gmail.com, Pedro Alves <palves@redhat.com>,
gbenson@redhat.com, dje@google.com, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: [PATCH] gdb/c-lang.c: Remove useless "err = 0;" instruction in c_get_string()
Date: Sun, 28 Sep 2014 00:46:00 -0000 [thread overview]
Message-ID: <20140928004647.GA6927@adacore.com> (raw)
In-Reply-To: <54267F0D.3070409@gmail.com>
> 'err' only has effect within a code block, so declare it within the code
> block, and remove useless "err = 0;" instruction.
>
> gdb/
> 2014-09-27 Chen Gang <gang.chen.5i5j@gmail.com>
>
> * c-lang.c (c_get_string): Remove useless "err = 0;" instruction.
Looks good to me. Go ahead and push.
--
Joel
prev parent reply other threads:[~2014-09-28 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 9:10 Chen Gang
2014-09-28 0:46 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928004647.GA6927@adacore.com \
--to=brobecker@adacore.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=dje@google.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox