From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116212-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28783 invoked by alias); 28 Sep 2014 00:46:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28763 invoked by uid 89); 28 Sep 2014 00:46:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 28 Sep 2014 00:46:51 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 5047011618B;	Sat, 27 Sep 2014 20:46:49 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id DmaABshjJxCR; Sat, 27 Sep 2014 20:46:49 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 12943116122;	Sat, 27 Sep 2014 20:46:49 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 828DC40E0E; Sat, 27 Sep 2014 17:46:47 -0700 (PDT)
Date: Sun, 28 Sep 2014 00:46:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: amodra@gmail.com, Pedro Alves <palves@redhat.com>, gbenson@redhat.com,	dje@google.com, gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH] gdb/c-lang.c: Remove useless "err = 0;" instruction in c_get_string()
Message-ID: <20140928004647.GA6927@adacore.com>
References: <54267F0D.3070409@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54267F0D.3070409@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2014-09/txt/msg00803.txt.bz2

> 'err' only has effect within a code block, so declare it within the code
> block, and remove useless "err = 0;" instruction.
> 
> gdb/
> 2014-09-27  Chen Gang  <gang.chen.5i5j@gmail.com>
> 
> 	* c-lang.c (c_get_string): Remove useless "err = 0;" instruction.

Looks good to me. Go ahead and push.

-- 
Joel