From: Joel Brobecker <brobecker@adacore.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>,
bug-readline@gnu.org, amodra@gmail.com,
Pedro Alves <palves@redhat.com>,
jan.kratochvil@redhat.com, drow@false.org,
ezannoni@kwikemart.cygnus.com, muller@sourceware.org,
Nicholas Clifton <nickc@redhat.com>,
gdb-patches@sourceware.org, binutils@sourceware.org,
macro@linux-mips.org
Subject: Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message()
Date: Mon, 22 Sep 2014 13:53:00 -0000 [thread overview]
Message-ID: <20140922135312.GB4883@adacore.com> (raw)
In-Reply-To: <mvmiokfst1x.fsf@hawking.suse.de>
> >> The related warning under Darwin x86_64:
> >>
> >> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
> >> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
> >> rl_message ("%s", p, 0);
> >> ~~~~ ^
> >> 1 warning generated.
> >>
> >>
> >> readline/ChangeLog.gdb:
> >>
> >> * search.c (_rl_nsearch_init): Remove useless parameter '0' for
> >> rl_message().
> >
> > Because readline is a separate project from binutils/GDB, we prefer
> > it if you would first submit the patch to the readline project first
> > (bug-readline@gnu.org, in Cc: of this email), get it accepted there.
>
> This bug was already fixed in bash 4.3.
I see! Sorry about the noise. For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?
--
Joel
next prev parent reply other threads:[~2014-09-22 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <541CF976.8090905@gmail.com>
2014-09-22 13:03 ` Joel Brobecker
2014-09-22 13:06 ` Andreas Schwab
2014-09-22 13:53 ` Joel Brobecker [this message]
[not found] ` <54204326.70005@gmail.com>
[not found] ` <54204823.7060503@case.edu>
[not found] ` <5420D422.60909@gmail.com>
2014-09-23 11:40 ` [Bug-readline] " Joel Brobecker
2014-09-22 13:08 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922135312.GB4883@adacore.com \
--to=brobecker@adacore.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bug-readline@gnu.org \
--cc=drow@false.org \
--cc=ezannoni@kwikemart.cygnus.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=macro@linux-mips.org \
--cc=muller@sourceware.org \
--cc=nickc@redhat.com \
--cc=palves@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox