From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10248 invoked by alias); 22 Sep 2014 13:53:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10222 invoked by uid 89); 22 Sep 2014 13:53:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 3 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 22 Sep 2014 13:53:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BFDEB1161B2; Mon, 22 Sep 2014 09:53:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eDRDUEYDO+KE; Mon, 22 Sep 2014 09:53:12 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 927D31161B1; Mon, 22 Sep 2014 09:53:12 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 44B0040E0D; Mon, 22 Sep 2014 09:53:12 -0400 (EDT) Date: Mon, 22 Sep 2014 13:53:00 -0000 From: Joel Brobecker To: Andreas Schwab Cc: Chen Gang , bug-readline@gnu.org, amodra@gmail.com, Pedro Alves , jan.kratochvil@redhat.com, drow@false.org, ezannoni@kwikemart.cygnus.com, muller@sourceware.org, Nicholas Clifton , gdb-patches@sourceware.org, binutils@sourceware.org, macro@linux-mips.org Subject: Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message() Message-ID: <20140922135312.GB4883@adacore.com> References: <541CF976.8090905@gmail.com> <20140922130324.GA4883@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00663.txt.bz2 > >> The related warning under Darwin x86_64: > >> > >> gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c > >> ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args] > >> rl_message ("%s", p, 0); > >> ~~~~ ^ > >> 1 warning generated. > >> > >> > >> readline/ChangeLog.gdb: > >> > >> * search.c (_rl_nsearch_init): Remove useless parameter '0' for > >> rl_message(). > > > > Because readline is a separate project from binutils/GDB, we prefer > > it if you would first submit the patch to the readline project first > > (bug-readline@gnu.org, in Cc: of this email), get it accepted there. > > This bug was already fixed in bash 4.3. I see! Sorry about the noise. For my penance, I pushed the patch in. Do we need it for 7.8.1 as well? -- Joel