From: Joel Brobecker <brobecker@adacore.com>
To: Gary Benson <gbenson@redhat.com>,
bug-hurd@gnu.org, thomas@codesourcery.com,
gdb-patches@sourceware.org
Subject: Re: [PATCHv4,Hurd] Add hardware watch support
Date: Fri, 12 Sep 2014 19:59:00 -0000 [thread overview]
Message-ID: <20140912195917.GG4871@adacore.com> (raw)
In-Reply-To: <20140912182911.GF3202@type.youpi.perso.aquilenet.fr>
Hello Samuel,
On Fri, Sep 12, 2014 at 08:29:11PM +0200, Samuel Thibault wrote:
> 2014-09-06 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> Add hardware watch support to gnu-i386 platform.
>
> This allows to get the "watch" command keep native code execution.
>
> * gdb/gdb/gnu-nat.c (inf_threads): New function.
> * gdb/gdb/gnu-nat.h (inf_threads_ftype): New type.
> (inf_threads): New declaration.
> * gdb/gdb/i386gnu-nat.c: Include "x86-nat.h" and "inf-child.h".
> [i386_DEBUG_STATE] (i386_gnu_dr_get, i386_gnu_dr_set,
> i386_gnu_dr_set_control_one, i386_gnu_dr_set_control,
> i386_gnu_dr_set_addr_one, i386_gnu_dr_set_addr, i386_gnu_dr_get_reg,
> i386_gnu_dr_get_addr, 386_gnu_dr_get_status, i386_gnu_dr_get_control):
> New functions
> (reg_addr): New structure.
> (_initialize_i386gnu_nat) [i386_DEBUG_STATE]: Initialize hardware i386
> debugging register hooks.
This is now OK. I double-checked that Samuel does have a copyright
assignment on file, so Thomas is good to go for pushing the patch in
if he approves as well. If Sergio has any further comment on the patch,
we can address them as followups.
Thank you,
--
Joel
next prev parent reply other threads:[~2014-09-12 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 18:29 Samuel Thibault
2014-09-12 19:59 ` Joel Brobecker [this message]
2014-09-12 20:01 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912195917.GG4871@adacore.com \
--to=brobecker@adacore.com \
--cc=bug-hurd@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox