From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21874 invoked by alias); 12 Sep 2014 19:59:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21860 invoked by uid 89); 12 Sep 2014 19:59:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 19:59:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0FBEF1165D6; Fri, 12 Sep 2014 15:59:19 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EPsI7g2dvyxw; Fri, 12 Sep 2014 15:59:19 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BF1BC1165CB; Fri, 12 Sep 2014 15:59:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9C75140E17; Fri, 12 Sep 2014 12:59:17 -0700 (PDT) Date: Fri, 12 Sep 2014 19:59:00 -0000 From: Joel Brobecker To: Gary Benson , bug-hurd@gnu.org, thomas@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [PATCHv4,Hurd] Add hardware watch support Message-ID: <20140912195917.GG4871@adacore.com> References: <20140912182911.GF3202@type.youpi.perso.aquilenet.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140912182911.GF3202@type.youpi.perso.aquilenet.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00462.txt.bz2 Hello Samuel, On Fri, Sep 12, 2014 at 08:29:11PM +0200, Samuel Thibault wrote: > 2014-09-06 Samuel Thibault > > Add hardware watch support to gnu-i386 platform. > > This allows to get the "watch" command keep native code execution. > > * gdb/gdb/gnu-nat.c (inf_threads): New function. > * gdb/gdb/gnu-nat.h (inf_threads_ftype): New type. > (inf_threads): New declaration. > * gdb/gdb/i386gnu-nat.c: Include "x86-nat.h" and "inf-child.h". > [i386_DEBUG_STATE] (i386_gnu_dr_get, i386_gnu_dr_set, > i386_gnu_dr_set_control_one, i386_gnu_dr_set_control, > i386_gnu_dr_set_addr_one, i386_gnu_dr_set_addr, i386_gnu_dr_get_reg, > i386_gnu_dr_get_addr, 386_gnu_dr_get_status, i386_gnu_dr_get_control): > New functions > (reg_addr): New structure. > (_initialize_i386gnu_nat) [i386_DEBUG_STATE]: Initialize hardware i386 > debugging register hooks. This is now OK. I double-checked that Samuel does have a copyright assignment on file, so Thomas is good to go for pushing the patch in if he approves as well. If Sergio has any further comment on the patch, we can address them as followups. Thank you, -- Joel