From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PUSHED] Remove useless gcore command detection (was: Re: [patch+7.8?] Fix 'gcore' with exited threads)
Date: Thu, 21 Aug 2014 18:29:00 -0000 [thread overview]
Message-ID: <20140821182904.GA19056@host2.jankratochvil.net> (raw)
In-Reply-To: <53F5CCC8.3010903@redhat.com>
On Thu, 21 Aug 2014 12:41:12 +0200, Pedro Alves wrote:
> On 08/17/2014 10:16 PM, Jan Kratochvil wrote:
> >> > I believe this is is stale -- gcore.o has been in COMMON_OBS for a while
> >> > now. I think the actual error will be whatever the default for the target
> >> > method throws.
> > Likewise two paragraphs above. Not sure what I should do with it:
> > * If I remove the test from this my testcase and someone later fixes
> > the 6 existing instances of this test this only test will remain unfixed.
> > * If I waste the time reading the sources what should be the expected output
> > I risk the test will not work anyway as I read it wrongly.
> > And I will probably wrongly modify 6 other testsuite cases.
> > * I can try to find a platform without gcore but in most cases in the past my
> > attempts to build GDB on any non-Linux platforms failed.
>
> No no, you misunderstand, we should just delete it completely.
> It's a useless test. See patch below.
I understood it perfectly. I just did not want to invest time into writing
the off-topic patch and writing its ChangeLog for the patch you wrote below.
It is now solved and I can remove the gcore test also from my patch, thanks.
Jan
next prev parent reply other threads:[~2014-08-21 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:30 [patch] Fix 'gcore' with exited threads Jan Kratochvil
2014-06-23 15:06 ` Pedro Alves
2014-08-17 21:16 ` [patch+7.8?] " Jan Kratochvil
2014-08-21 10:41 ` [PUSHED] Remove useless gcore command detection (was: Re: [patch+7.8?] Fix 'gcore' with exited threads) Pedro Alves
2014-08-21 18:29 ` Jan Kratochvil [this message]
2014-08-21 11:33 ` [patch+7.8?] Fix 'gcore' with exited threads Pedro Alves
2014-08-21 18:45 ` [commit+7.8] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821182904.GA19056@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox